A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Mar 01, 2012 at 08:08:27AM +0000, Chris Kelly wrote: > Concerning the data structure: this is indeed exported to user space. > Is the problem that it should only use "__" data types (e.g. __u32) > and that the "header-" line is missing from Kbuild or have I done > other things wrong? Oh, where to start :) First off, why have an ioctl at all? We really don't like adding them, it's as if you just created your own special system call just for this driver. >From a technical point of view, yes, you need to use the "__u32" style definitions for your variables (hint, int does not mean what you think it means on some systems), you need to handle the 32/64 user/kernel split properly for some machines, and you need to ensure that your field alignments are also correct. And you use a pointer, which gets really messy for the 32/64 changes, so you need a special function just to handle that. And you need the structure to be exported to userspace, as you say, with the Kbuild change and the proper KERNEL markings in the .h file. You said it's for debugging, so we can remove it, that's great, you might want to look into debugfs, as that is what it is for, if you need debugging stuff for your driver. It's probably easier and simpler to do that than to try to fix this up. Hope this helps, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
