Re: [PATCH] usb: core: hcd: make hcd->irq unsigned

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> I think you may have missed a couple spots in the xHCI driver, in
> xhci_try_enable_msi():
> 
>         /* unregister the legacy interrupt */
>         if (hcd->irq)
>                 free_irq(hcd->irq, hcd);
>         hcd->irq = -1;
> 
>         ret = xhci_setup_msix(xhci);
>         if (ret)
>                 /* fall back to msi*/
>                 ret = xhci_setup_msi(xhci);
> 
>         if (!ret)
>                 /* hcd->irq is -1, we have MSI */
>                 return 0;
> 
> You probably want to change both the set to -1 and the comment above the
> return on MSI enabled.
> 
> Alex, you'll need to rebase your MSI enabling patchset against Felipe's
> when it gets into Greg's usb-next branch.

See, thanks for reminder! 


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux