Dear Sergei, Sorry I misunderstand it. I'll correct the format and re-submit soon. Thanks. BR. Meng Zhang -----Original Message----- From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb-owner@xxxxxxxxxxxxxxx] On Behalf Of Meng Zhang (张萌) Sent: Tuesday, February 28, 2012 8:00 PM To: Sergei Shtylyov Cc: mdharm-usb@xxxxxxxxxxxxxxxxxx; phil@xxxxxxxx; stern@xxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; usb-storage@xxxxxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx Subject: RE: [PATCH] USB: Mass Storage: Add MediaTek MT6276M device entry Hi, about the indentation I saw in initializers.c is also tab with 2 spaces.. should I change this to 2 tabs manually? Thanks! BR. Meng Zhang -----Original Message----- From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb-owner@xxxxxxxxxxxxxxx] On Behalf Of Sergei Shtylyov Sent: Tuesday, February 28, 2012 7:39 PM To: Meng Zhang (张萌) Cc: mdharm-usb@xxxxxxxxxxxxxxxxxx; phil@xxxxxxxx; stern@xxxxxxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; usb-storage@xxxxxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx Subject: Re: [PATCH] USB: Mass Storage: Add MediaTek MT6276M device entry Hello. On 28-02-2012 13:08, Meng Zhang wrote: > from: Meng Zhang <meng.zhang@xxxxxxxxxxxx> > 1. Add entrys for mediatek MT6276M in unusual_devs.h > 2. Add init function for mediatek MT6276M to switch to COM port mode > 3. usb-devices outputs after running with this patch: > T: Bus=02 Lev=01 Prnt=01 Port=05 Cnt=01 Dev#= 48 Spd=480 MxCh= 0 > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=0e8d ProdID=00a1 Rev=02.00 > S: Manufacturer=MediaTek Inc > S: Product=Product > C: #Ifs= 3 Cfg#= 1 Atr=80 MxPwr=500mA > I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=02 Prot=01 Driver=option > I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option > 4. patch based on branch: > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git This information (4) should be under the --- tear line. > Signed-off-by: Meng Zhang <meng.zhang@xxxxxxxxxxxx> [...] > diff --git a/drivers/usb/storage/initializers.c > b/drivers/usb/storage/initializers.c > index 105d900..44985a1 100644 > --- a/drivers/usb/storage/initializers.c > +++ b/drivers/usb/storage/initializers.c > @@ -104,3 +104,30 @@ int usb_stor_huawei_e220_init(struct us_data *us) > US_DEBUGP("Huawei mode set result is %d\n", result); return 0; } > + > +/* switch MediaTek MT6276M to COM port mode */ int > +usb_stor_mediatek_mt6276m_init(struct us_data *us) { const unsigned > +char rezero_msg[] = { Unfortunately, when I reply to messages with "format=flowed", source formatting is spoiled. :-( > + 0x55, 0x53, 0x42, 0x43, 0x78, 0x56, 0x34, 0x12, All indentation here should be done with tabs, not tab and two spaces. > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x06, 0xf0, 0x01, 0x03, 0x00, > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0x00 }; WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html 韬{.n?壏煯壄?%娝lzwm呴b濍Р骒r笡zXЩ琻)韰骅w*jg?秹殠娸/侁鋤罐枈?娹櫒璀??摺玜囤瓽珴閔?鎗:+v墾妛鑶佶 ��.n��������+%������w��{.n�����{���)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥