Hi, On Tue, Feb 28, 2012 at 10:37:52AM -0500, Alan Stern wrote: > On Tue, 28 Feb 2012, Felipe Balbi wrote: > > > There's really no point in having hcd->irq as a > > signed integer when we consider the fact that > > IRQ 0 means NO_IRQ. In order to avoid confusion, > > make hcd->irq unsigned and fix users who were > > passing -1 as the IRQ number to usb_add_hcd. > > > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > > I haven't tried compiling this to make sure no warnings crop up, but > the patch itself is certainly the right thing to do. > > Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> I did :-) no warnings at all (only the normal ones at MUSB, thanks for the Blackfin folks never fixing their issues): $ make -j8 drivers/usb/ > /dev/null drivers/usb/musb/musb_gadget.c: In function ‘musb_gadget_enable’: drivers/usb/musb/musb_gadget.c:1085:3: warning: ‘double_buffer_not_ok’ is deprecated (declared at drivers/usb/musb/musb_core.h:452) [-Wdeprecated-declarations] drivers/usb/musb/musb_gadget.c:1125:3: warning: ‘double_buffer_not_ok’ is deprecated (declared at drivers/usb/musb/musb_core.h:452) [-Wdeprecated-declarations] drivers/usb/musb/musb_host.c: In function ‘musb_rx_reinit’: drivers/usb/musb/musb_host.c:599:2: warning: ‘double_buffer_not_ok’ is deprecated (declared at drivers/usb/musb/musb_core.h:452) [-Wdeprecated-declarations] drivers/usb/musb/musb_host.c: In function ‘musb_ep_program’: drivers/usb/musb/musb_host.c:774:4: warning: ‘double_buffer_not_ok’ is deprecated (declared at drivers/usb/musb/musb_core.h:452) [-Wdeprecated-declarations] -- balbi
Attachment:
signature.asc
Description: Digital signature
