Hi, On Tue, Feb 28, 2012 at 06:45:46PM +0800, Peter Chen wrote: > - For Control Read transfer, the ACK handshake on an IN transaction > may be corrupted, so the device may not receive the ACK for data > stage, the complete irq will not occur at this situation. > Therefore, we need to move prime status stage from complete irq > routine to the place where the data stage has just primed, or the > host will never get ACK for status stage. > The above issue has benn described at USB2.0 spec ch8.5.3.3. > > - After adding prime status stage just after prime the data stage, > there is a potential problem when the status dTD is added before the data stage > has primed by hardware. The reason is the device's dTD descritor has NO direction bit, > if data stage (IN) prime hasn't finished, the status stage(OUT) > dTD will be added at data stage dTD's Next dTD Pointer, so when the data status > transfer has finished, the status dTD will be primed as IN by hardware, > then the host will never receive ACK from the device side at status stage. > > - Delete below code at fsl_ep_queue: > /* Update ep0 state */ > if ((ep_index(ep) == 0)) > udc->ep0_state = DATA_STATE_XMIT; > the udc->ep0_state will be updated again after udc->driver->setup > finishes. > > It is tested at i.mx51 bbg board with g_mass_storage, g_ether, g_serial. > > Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx> I'm giving up on this patch for now. There's still a typo on the commit message and you're adding whitespaces to the driver. Before resending, make sure you run checkpatch.pl --strict and sparse on your changes and carefully read your commit log to make sure there are no typos. -- balbi
Attachment:
signature.asc
Description: Digital signature
