On Mon, 27 Feb 2012, LiuShuo wrote: > > - /* software reset of the controller, preserving HcFmInterval */ > > - fminterval = readl(base + OHCI_FMINTERVAL); > > - writel(OHCI_HCR, base + OHCI_CMDSTATUS); > > + /* software reset of the controller, preserving HcFmInterval */ > > + fminterval = readl(base + OHCI_FMINTERVAL); > Hi Stern, > This patch maybe introduce a bug. Test on freescale P2020ds board : > System will hang at this point. (fminterval = readl(base + > OHCI_FMINTERVAL);) You know, you don't have to include the _entire_ patch if you're going to comment only on that one little section. > I found that these code only are executed when pdev->vendor is > PCI_VENDOR_ID_NVIDIA before > this patch. That's not entirely true. The same register gets read later on in ohci_run() for every vendor. Even for non-PCI controllers. > Should it always be executed with any vendor id ? > (the vendor id of our chip is PCI_VENDOR_ID_AL) What's wrong with your chip? Why can't it handle a simple read of the HcFmInterval register? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
