Re: [PATCH 1/3] usb/storage: a couple defines from drivers/usb/storage/transport.h to include/linux/usb/storage.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Greg KH | 2012-02-24 13:42:12 [-0800]:

>After applying this patch, I get the following build error:
>
>In file included from drivers/staging/keucr/usb.c:18:0:
>drivers/staging/keucr/transport.h:9:8: error: redefinition of ???struct bulk_cb_wrap???
>include/linux/usb/storage.h:53:8: note: originally defined here
>drivers/staging/keucr/transport.h:25:8: error: redefinition of ???struct bulk_cs_wrap???
>include/linux/usb/storage.h:69:8: note: originally defined here
>
>Please use 'git grep' when making system-wide changes.

I saw that and assumed it brings its own headers and does not use the
public include/. Now looking back at it I have no idea why I came to
such a stupid conclusion. I hope it is a temporary condition...

What I did miss and found this time are the defines in
drivers/block/ub.c. The new series considers them all.

Now that I looked at the ub.c driver I feel like removing more stuff. On
the first look, it seems to do same thing as the storage driver in
drivers/usb/storage. It is not enable on Debian sid box and it is also
not enabled on my FC15 box. This makes me ask the following question:
May I remove it or are there some users which can not use the storage
driver?

>Care to redo this series?
Sure.

>thanks,
>
>greg k-h

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux