HI Alan, > -----Original Message----- > From: Alan Stern [mailto:stern@xxxxxxxxxxxxxxxxxxx] > Sent: 2012年2月24日 1:00 > To: Neil Zhang > Cc: Tanmay Upadhyay; gregkh@xxxxxxxxxxxxxxxxxxx; USB list; Chao Xie > Subject: Re: [PATCH] usb: host: add dependence for USB_EHCI_MV > > On Thu, 23 Feb 2012, Neil Zhang wrote: > > > This ehci driver is mainly designed to support host controller found > on > > Marvell PXA and MMP Soc series. > > Add the dependence to avoid the potential build failure which may > > include two EHCI controller drivers. > > > > Signed-off-by: Neil Zhang <zhangwm@xxxxxxxxxxx> > > --- > > drivers/usb/host/Kconfig | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig > > index 353cdd4..280332f 100644 > > --- a/drivers/usb/host/Kconfig > > +++ b/drivers/usb/host/Kconfig > > @@ -196,7 +196,7 @@ config USB_EHCI_S5P > > > > config USB_EHCI_MV > > bool "EHCI support for Marvell on-chip controller" > > - depends on USB_EHCI_HCD > > + depends on USB_EHCI_HCD && (ARCH_PXA || ARCH_MMP) > > select USB_EHCI_ROOT_HUB_TT > > ---help--- > > Enables support for Marvell (including PXA and MMP series) on- > chip > > The section for USB_PXA168_EHCI also depends on ARCH_MMP. Do you think > that ehci_pxa168.c should be removed because ehci_mv.c can take over > for it? If so, please send in a patch removing ehci_pxa168.c along > with its associated lines in Kconfig and Makefile. Yes, I have test the driver ehci_mv.c on PXA168, it works well. So, I'm going to send a patch to remove ehci_pxa168.c. > > Alan Stern Best Regards, Neil Zhang ?韬{.n?????%??檩??w?{.n???{炳???骅w*jg????????G??⒏⒎?:+v????????????"??????