On Thu, 23 Feb 2012, Jingoo Han wrote:
> This patch removes uses of hcd->state and replaces hcd->state with
> ohci->rh_state field.
>
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> ---
> drivers/usb/host/ohci-exynos.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c
> index 55aa35a..37bb20e 100644
> --- a/drivers/usb/host/ohci-exynos.c
> +++ b/drivers/usb/host/ohci-exynos.c
> @@ -212,12 +212,10 @@ static int exynos_ohci_suspend(struct device *dev)
> * mark HW unaccessible, bail out if RH has been resumed. Use
> * the spinlock to properly synchronize with possible pending
> * RH suspend or resume activity.
> - *
> - * This is still racy as hcd->state is manipulated outside of
> - * any locks =P But that will be a different fix.
> */
> spin_lock_irqsave(&ohci->lock, flags);
> - if (hcd->state != HC_STATE_SUSPENDED && hcd->state != HC_STATE_HALT) {
> + if (ohci->rh_state != OHCI_RH_SUSPENDED &&
> + ohci->rh_state != OHCI_RH_HALTED) {
> rc = -EINVAL;
> goto fail;
> }
Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
