On Thu, Jan 19, 2012 at 11:25:58PM +0800, Alex Shi wrote: > > I think this code is backwards. In xhci-pci.c, when we detect the xHCI > > chipsets with broken MSI, we should clear the HCD_MSI_FIRST flag, and > > allow the USB core to set up the legacy PCI interrupt. Then this > > function should just return when it detects the XHCI_BROKEN_MSI quirk > > (before it sets hcd->irq to -1). That way any changes to the legacy PCI > > IRQ setup normal flow in the USB core will also effect these xHCI hosts > > that really need it. > > Sorry for response later, I backed to my hometown from Jan 16 yo Jan 28. > and have a bad Internet connection. :( No problem. It's the chinese new year, correct? > how about the following: Yes, that looks like what I'm after. Can you respin the patchset with this change? > > The first patch looks fine, although I would have to apply it to see the > > changes. BTW, have you tested the code on the Intel Panther Point xHCI > > host to make sure it works when CONFIG_PCI_MSI is turned off? And by > > "works" I mean that xHCI probe fails when MSI is turned off for Panther > > Point systems. > > > > I am sorry for can not try this. Because I need the PCIe NIC to remote > access on the machine from home, if turn off the MSI, It will lose the > only connection for this machine. I see. > Are ther anyone like to do this try? > or after I am back to office. I'll try your patch tomorrow with MSI turned off when I'm also back in the office. If you don't hear from me by the time you get back from your vacation, you can try it out yourself. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
