[Re: [PATCH] usb: fix warnings from emi26/emi62 drivers] On 21/01/2012 (Sat 22:33) Alan Stern wrote: > On Sat, 21 Jan 2012, Paul Gortmaker wrote: > > > These warnings: > > > > drivers/usb/misc/emi26.c:40:19: warning: ‘emi26_init’ declared ‘static’ but never defined [-Wunused-function] > > drivers/usb/misc/emi26.c:41:20: warning: ‘emi26_exit’ declared ‘static’ but never defined [-Wunused-function] > > drivers/usb/misc/emi62.c:49:19: warning: ‘emi62_init’ declared ‘static’ but never defined [-Wunused-function] > > drivers/usb/misc/emi62.c:50:20: warning: ‘emi62_exit’ declared ‘static’ but never defined [-Wunused-function] > > > > are as claimed. There are no such init/exit functions. Delete > > the associated prototypes. > > This may be a silly question... Why do we have both an emi26.c and an > emi62.c driver? The two files are nearly identical. At a quick glance, I would have to agree. But that crime was done long ago, and this patch actually reduces the delta between the two. So if someone with the hardware wants to merge the drivers, then great! But for now, I think we should start by adding this patch. Paul. > > Alan Stern > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
