Hello. On 20-01-2012 4:50, Bjørn Mork wrote:
Monitoring clients will want this feature on devices which do not echo back the command for us. Make it a per-device-id configurable item and disabled by default, as it represents a behavioural change
This is preparing for supporting devices using other protocols than AT commands. Such devices will typically not echo back the received command.
Signed-off-by: Bjørn Mork<bjorn@xxxxxxx>
[...]
diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c index bd0cb5f..e0c17ff 100644 --- a/drivers/usb/class/cdc-wdm.c +++ b/drivers/usb/class/cdc-wdm.c
[...]
@@ -371,6 +376,16 @@ static ssize_t wdm_write } else { dev_dbg(&desc->intf->dev, "Tx URB has been submitted index=%d", desc->orq->wIndex); + /* + * echo command if device attribute says so. + * Note: we don't update the file pointer on write, so + * this we will read this back ourselves as well
"So that we will read" maybe? WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html