Re: [PATCH v2] usb/uhci: initialize sg_table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 13 Jan 2012, Sebastian Andrzej Siewior wrote:

> Commit 689d6eac ("USB: UHCI: add native scatter-gather support(v1))
> added sg support to uhci but forgot to set the sg_table so this feature
> remained unused.
> 
> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> Cc: Ming Lei <tom.leiming@xxxxxxxxx>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> ---
> v1..v2: moved to uhci_start() as suggested by Alan.
> 
>  drivers/usb/host/uhci-hcd.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/host/uhci-hcd.c b/drivers/usb/host/uhci-hcd.c
> index c8ae199..167be7e 100644
> --- a/drivers/usb/host/uhci-hcd.c
> +++ b/drivers/usb/host/uhci-hcd.c
> @@ -565,6 +565,9 @@ static int uhci_start(struct usb_hcd *hcd)
>  	struct dentry __maybe_unused *dentry;
>  
>  	hcd->uses_new_polling = 1;
> +	/* Accept arbitrarily long scatter-gather lists */
> +	if (!(hcd->driver->flags & HCD_LOCAL_MEM))
> +		hcd->self.sg_tablesize = ~0;
>  
>  	spin_lock_init(&uhci->lock);
>  	setup_timer(&uhci->fsbr_timer, uhci_fsbr_timeout,

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux