On 01/12/2012 11:37 PM, Alan Stern wrote: > On Thu, 12 Jan 2012, Alex,Shi wrote: > >> Thanks, Sarah. I understand your concern now. >> Maybe checking MSI first in usb_hcd_request_irqs is your favorite too, >> right? >> >> I take a quick glance on the code. May we have 2 ways to implement it. >> >> A, move current xhci code and a few MSI related objects into usb_hcd >> core code and structure. the skeleton like below. > > MSI is used only for PCI, right? Therefore we should try to keep as > much as possible of the core MSI-related code in hcd-pci.c, not in > hcd.c. > Reasonable! So maybe do the MSI enabling in usb_hcd_pci_probe is more suitable. but wherever we do MSI enabling, the code in xhci will be redundant. I want to hear Sarah's comments. :) -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
