Re: [PATCH] drivers: usb: gadget: f_mass_storage: Use "bool" instead of "int" in fsg_module_parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 12, 2012 at 2:15 PM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
Really?  Even the removable, can_stall, and cdrom fields?

On Thu, 12 Jan 2012 17:18:57 +0100, Fabio Estevam <festevam@xxxxxxxxx> wrote:
Yes, on linux-next they are converted to "bool" already.

Please check:
http://git.kernel.org/?p=linux/kernel/git/next/linux-next-history.git;a=blob;f=drivers/usb/gadget/file_storage.c;h=47766f0e7caa320796f7894d8144a3933ff1393f;hb=HEAD

Ah, now I see.  493c90ef201f1960c2e2b606d1fb432c408bdf35[1] changed the
moduleparam.h so that bool parameter type now requires bool type and no
longer allows (unsigned) int.

In that case, I would rewrite the commit message a bit to inform that the
change is needed because of that commit[1], but even without that you get
my Ack. :)

[1] http://git.kernel.org/?p=linux/kernel/git/next/linux-next-history.git;a=commit;h=493c90ef201f1960c2e2b606d1fb432c408bdf35

--
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux