On Wed, 11 Jan 2012, Sarah Sharp wrote: > On Thu, Jan 12, 2012 at 09:04:34AM +0800, Alex,Shi wrote: > > > > > This doesn't belong here either. All it does is remove code that was > > > added by the previous patch. If you don't want the code, don't add it > > > in the first place. > > > > Did you mean to merge the 2 patches into one? That should resolve your > > concern. So, how about the following new patch. > > No, Alan meant that, in a patchset, you shouldn't add comments or code, > only to have delete them in the next patchset. The whole patchset needs > to be clean, with each patch being in its final form, so that bisection > works to find out where a bug was introduced. If you submit a patchset > where you introduce some buggy code, and then delete it in a later > patch, the bisect might fail. You can use git rebase, git reset --mixed, > and git add -p to move code changes from one patch in a series to > another. > > I can't say whether he meant you should merge all your patches into one > patch, but I don't think that was Alan's intent. That's right. It makes no sense to add code and comments on patch 1 and then remove them in patch 2. As for whether or not to merge all the changes into one patch, that's really up to Sarah. She's the xHCI maintainer. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
