On Sun, Jan 08, 2012 at 05:17:54PM +0400, Sergei Shtylyov wrote: > Hello. > > On 07-01-2012 22:33, Oliver Neukum wrote: > > >>--- a/drivers/usb/host/xhci-mem.c > >>+++ b/drivers/usb/host/xhci-mem.c > >>@@ -2141,7 +2141,7 @@ int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags) > >> unsigned int val, val2; > >> u64 val_64; > >> struct xhci_segment *seg; > >>- u32 page_size; > >>+ u32 page_size, temp; > >> int i; > >> > >> page_size = xhci_readl(xhci,&xhci->op_regs->page_size); > >>@@ -2324,6 +2324,14 @@ int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags) > >> > >> INIT_LIST_HEAD(&xhci->lpm_failed_devs); > >> > >>+ /* Enable USB 3.0 device notifications for function remote wake, which > >>+ * is necessary for allowing USB 3.0 devices to do remote wakeup from > >>+ * U3 (device suspend). > >>+ */ > >>+ temp = xhci_readl(xhci,&xhci->op_regs->dev_notification); > >>+ temp &= ~(DEV_NOTE_MASK); > > Also, why parens here? I thought you weren't going to send non-constructive reviews for my patches anymore. If checkpatch.pl doesn't catch it, it's not useful to ask people to fix. Don't waste my time (and yours). Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
