On Wed, Jan 4, 2012 at 5:44 AM, Kevin Hilman <khilman@xxxxxx> wrote: > Shubhrajyoti D <shubhrajyoti@xxxxxx> writes: > >> Currently the runtime functions are compiled regardless >> of CONFIG_PM_RUNTIME flag. This patch intends to fix the same by >> using SET_RUNTIME_PM_OPS. >> >> Cc : Keshava Munegowda <keshava_mgowda@xxxxxx> >> Signed-off-by: Shubhrajyoti D <shubhrajyoti@xxxxxx> >> --- >> applies on Tony's ehci branch. >> Compile tested only. > > You also should compile test this with runtime PM disabled. I believe > the current patch will lead to 'function defined but not used' warnings. Agree . thanks for pointing out. > > Kevin > >> drivers/mfd/omap-usb-host.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c >> index 3f565ef..ef72ebe 100644 >> --- a/drivers/mfd/omap-usb-host.c >> +++ b/drivers/mfd/omap-usb-host.c >> @@ -887,8 +887,8 @@ static int __devexit usbhs_omap_remove(struct platform_device *pdev) >> } >> >> static const struct dev_pm_ops usbhsomap_dev_pm_ops = { >> - .runtime_suspend = usbhs_runtime_suspend, >> - .runtime_resume = usbhs_runtime_resume, >> + SET_RUNTIME_PM_OPS(usbhs_runtime_suspend, >> + usbhs_runtime_resume, NULL) >> }; >> >> static struct platform_driver usbhs_omap_driver = { > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html