Re: [PATCH] usb: descriptor field name fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 04, 2012 at 03:04:24PM +0800, Andiry Xu wrote:
> On 01/03/2012 09:44 AM, Sarah Sharp wrote:
> > Hi Andiry,
> > 
> > On Thu, Dec 22, 2011 at 02:23:06PM +0800, Andiry Xu wrote:
> >> Rename the fields in USB SS device capability descriptor to comply
> >> with USB3.0 specification.
> > 
> > This is more than a simple rename, right?  Most of it is a rename, but
> > there's also a bug fix in the composite driver to make sure it converts
> > the default U2 latency to le16.  Maybe that should be a separate bug fix
> > marked for stable before the rename patch?
> > 
> 
> Actually, this patch is a rename patch. Composite driver already uses
> cpu_to_le16() and I did not touch it. But after double-check I do find

that's not what your patch shows:

> >> -		dcd_config_params.bU1devExitLat = USB_DEFAULT_U1_DEV_EXIT_LAT;
> >> -		dcd_config_params.bU2DevExitLat =
> >> +		dcd_config_params.bU1DevExitLat = USB_DEFAULT_U1_DEV_EXIT_LAT;
> >> +		dcd_config_params.wU2DevExitLat =
> >>  			cpu_to_le16(USB_DEFAULT_U2_DEV_EXIT_LAT);
> >>  	}

> some endian issues in storage gadget driver. I will re-submit the
> patchset, a bug fix patch followed by the rename patch.

cool, thanks

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux