On Sat, 7 Jan 2012, Alan Stern wrote:
> > - if (portchange & USB_PORT_STAT_C_LINK_STATE) {
> > + /* We can't clear the link state change here because it's the
> > + * only indication we have a resume on a port!
> > + */
> > + if (portchange & USB_PORT_STAT_C_LINK_STATE)
> > need_debounce_delay = true;
> > - clear_port_feature(hub->hdev, port1,
> > - USB_PORT_FEAT_C_PORT_LINK_STATE);
> > - }
>
> I'd suggest leaving in the {}'s, even though technically the body is
> only a single statement -- the comments make it look like a
> multi-statement body. In addition, the comments need to be indented
> one tab stop farther.
Oops... Forget all that; I read the patch wrong. The formatting is
fine. (But the comment and the debounce delay may still be
unnecessary.)
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
