On Wed, Jan 04, 2012 at 10:54:22PM -0500, Alan Stern wrote: > On Wed, 4 Jan 2012, Greg KH wrote: > > > On Wed, Jan 04, 2012 at 07:25:33PM +0800, Huajun Li wrote: > > > Echo vendor and product number of a non usb-storage device to > > > usb-storage driver's new_id, then plug in the device to host and you > > > will find following oops msg, the root cause is usb_stor_probe1() > > > refers invalid id entry if giving a dynamic id, so just disable the > > > feature. > > > > How about fixing this so it works properly? > > > > I'll take this patch now, but fixing the feature really would be nice to > > have, right? > > This should be easy enough, by adding an extra check to > storage_probe(). If id doesn't lie between the start and end of > usb_storage_usb_ids then it must come from a dynamic ID. In that case, > pass usb_stor_probe1() a fixed usb_device_id entry that describes a > device using the Bulk-Only transport with the Transparent SCSI > protocol. > > The various subdrivers, like alauda, datafab, and so on, probably > should have their no_dynamic_id flags set. They could be fixed up in > the same way, but it would be a lot of work with very little gain. Ok, that sounds good, anyone want to send a patch? I'm waist deep in stable kernel releases and the merge window at the moment, not to mention my "real job" to be able to do this for a few weeks. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
