Re: [PATCH] usb: usb-storage doesn't support dynamic id currently, the patch disables the feature to fix an oops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 5, 2012 at 8:03 AM, Greg KH <greg@xxxxxxxxx> wrote:
> On Wed, Jan 04, 2012 at 07:25:33PM +0800, Huajun Li wrote:
>> Echo vendor and product number of a non usb-storage device to
>> usb-storage driver's new_id, then plug in the device to host and you
>> will find following oops msg, the root cause is usb_stor_probe1()
>> refers invalid id entry if giving a dynamic id, so just disable the
>> feature.
>
> How about fixing this so it works properly?
>
Hi Greg,
   Did not find issues per my test after applied the patch.

> I'll take this patch now, but fixing the feature really would be nice to
> have, right?
>
Yes. I thought about the feature before I submitted the patch, but it
need a nice solution.

Just as Alan said in the other email, if storage_probe() finds the id
is a dynamic one,  "pass usb_stor_probe1() a fixed usb_device_id entry
that describes a device using the Bulk-Only transport with the
Transparent SCSI protocol."
However, maybe this still hard to make the device work if it is not a
device of Bulk-Only transport with SCSI protocol, for example, it
needs "Control/Bulk" transport.

> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux