On Tue, Dec 20, 2011 at 1:19 PM, Felipe Balbi <balbi@xxxxxx> wrote: > On Mon, Dec 19, 2011 at 10:20:09PM +0200, Felipe Contreras wrote: >> On Mon, Dec 19, 2011 at 10:11 AM, Felipe Balbi <balbi@xxxxxx> wrote: >> > On Fri, Dec 16, 2011 at 01:05:08AM +0200, Felipe Contreras wrote: >> >> Properly call pm_runtime_put() afer pm_runttime_get() on errors. >> >> >> >> Untested. >> > >> > sorry, but I'm not applying untested patches. I need someone to give a >> > Tested-by. >> >> I'm pretty sure most people don't test the exit paths, but fine, don't >> apply them. Who needs power management anyway. > > if it wasn't tested you can't claim $SUBJECT makes PM magically work. It's clear from the code, no need to test to see that pm_runtime_get() is called but not pm_runtime_put(), thus the device remains active, thus PM would not work after that. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
