Re: [PATCH 8/8] s3c-hsudc: remove the_controller global

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 19, 2011 at 07:43:35PM +0100, Heiko Stübner wrote:
> Instead use container_of to retrieve the s3c_hsudc from the
> struct usb_gadget pointer.
> 
> Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx>
> ---
>  drivers/usb/gadget/s3c-hsudc.c |   11 ++++++-----
>  1 files changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c
> index 8e69758..23cac9d 100644
> --- a/drivers/usb/gadget/s3c-hsudc.c
> +++ b/drivers/usb/gadget/s3c-hsudc.c
> @@ -161,7 +161,6 @@ struct s3c_hsudc {
>  #define ep_index(_ep)		((_ep)->bEndpointAddress & \
>  					USB_ENDPOINT_NUMBER_MASK)
>  
> -static struct s3c_hsudc *the_controller;
>  static const char driver_name[] = "s3c-udc";
>  static const char ep0name[] = "ep0-control";
>  
> @@ -1141,7 +1140,8 @@ static irqreturn_t s3c_hsudc_irq(int irq, void *_dev)
>  static int s3c_hsudc_start(struct usb_gadget *gadget,
>  		struct usb_gadget_driver *driver)
>  {
> -	struct s3c_hsudc *hsudc = the_controller;
> +	struct s3c_hsudc *hsudc =
> +			container_of(gadget, struct s3c_hsudc, gadget);

I have changed all these container_of() to your to_hsudc() helper
function.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux