Hi,
On Mon, Dec 19, 2011 at 12:58:34PM +0100, Sebastian Andrzej Siewior wrote:
> * Felipe Balbi | 2011-12-19 13:04:06 [+0200]:
>
> >--- a/drivers/usb/dwc3/ep0.c
> >+++ b/drivers/usb/dwc3/ep0.c
> >@@ -443,10 +443,13 @@ static int dwc3_ep0_set_address(struct dwc3 *dwc, struct usb_ctrlrequest *ctrl)
> > reg |= DWC3_DCFG_DEVADDR(addr);
> > dwc3_writel(dwc->regs, DWC3_DCFG, reg);
> >
> >- if (addr)
> >+ if (addr) {
> > dwc->dev_state = DWC3_ADDRESS_STATE;
> >- else
> >+ usb_gadget_set_status(&dwc->gadget, USB_STATUS_ADDRESSED);
> >+ } else {
> > dwc->dev_state = DWC3_DEFAULT_STATE;
> >+ usb_gadget_set_status(&dwc->gadget, USB_STATUS_DEFAULT);
>
> Looks good in general. Do you think it would make sense to get rid of
> dwc3's internal dev_state?
don't see why not.
--
balbi
Attachment:
signature.asc
Description: Digital signature
