Hi Babli, > -----Original Message----- > From: Felipe Balbi [mailto:balbi@xxxxxx] > Sent: 2011年12月19日 16:08 > To: Felipe Balbi > Cc: Neil Zhang; stern@xxxxxxxxxxxxxxxxxxx; gregkh@xxxxxxx; Chao Xie; > linux-usb@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 01/10 v5] usb: gadget: mv_udc: drop ARCH dependency > > Hi, > > On Mon, Dec 19, 2011 at 10:01:38AM +0200, Felipe Balbi wrote: > > Hi, > > > > On Thu, Dec 15, 2011 at 07:26:37PM +0800, Neil Zhang wrote: > > > This patch do the following things: > > > 1. Change the Kconfig information. > > > 2. Rename the driver name. > > > 3. Don't do any type cast to io memory. > > > 4. Add dummy stub for clk framework. > > > > > > Signed-off-by: Neil Zhang <zhangwm@xxxxxxxxxxx> > > > > you have not compiled this change on x86 have you ? I have compiled this on x86 at my side. > > > > CC [M] drivers/usb/gadget/mv_udc_core.o > > drivers/usb/gadget/mv_udc_core.c: In function ‘queue_dtd’: > > drivers/usb/gadget/mv_udc_core.c:347:12: error: implicit declaration > > of function ‘dma_to_virt’ [-Werror=implicit-function-declaration] > > drivers/usb/gadget/mv_udc_core.c:347:31: warning: initialization > makes This issue is fixed by patch 3. > > pointer from integer without a cast [enabled by default] > > drivers/usb/gadget/mv_udc_core.c: In function ‘mv_ep_dequeue’: > > drivers/usb/gadget/mv_udc_core.c:894:11: warning: cast from pointer > to > > integer of different size [-Wpointer-to-int-cast] > > drivers/usb/gadget/mv_udc_core.c: In function ‘mv_udc_get_frame’: > > drivers/usb/gadget/mv_udc_core.c:1199:2: warning: passing argument 1 > of ‘readl’ makes pointer from integer without a cast [enabled by > default] > > arch/x86/include/asm/io.h:55:1: note: expected ‘const volatile void *’ > but argument is of type ‘u32’ This issue is fixed by patch 2. > > drivers/usb/gadget/mv_udc_core.c: In function ‘mv_udc_probe’: > > drivers/usb/gadget/mv_udc_core.c:2274:47: warning: cast from pointer > > to integer of different size [-Wpointer-to-int-cast] > > drivers/usb/gadget/mv_udc_core.c:2274:17: warning: cast to pointer > > from integer of different size [-Wint-to-pointer-cast] > > cc1: some warnings being treated as errors > > > make[2]: *** [drivers/usb/gadget/mv_udc_core.o] Error 1 > > make[1]: *** [drivers/usb/gadget] Error 2 > > make: *** [drivers/usb/] Error 2 > > > > Fix it ASAP or this won't make it into 3.3 merge window. I will see > if > > I apply the others but you must fix this one. > most of these patches didn't apply. Please rebase on my master branch > so I can apply these patches cleanly. I want to send another pull > request ot Greg this wednesday or thursday. Linus has said that he > probably won't make an -rc8, so we I want to give the patches some time > on linux-next before they go in the next merge window. > Ok, I will rebase it and do a clean build then. > -- > Balbi Best Regards, Neil Zhang ��.n��������+%������w��{.n�����{���)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
