Re: [PATCH v3 5/5] usb: dwc3: gadget: add support for SG lists

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/16/2011 04:13 PM, Felipe Balbi wrote:

@@ -1989,6 +2069,7 @@ int __devinit dwc3_gadget_init(struct dwc3 *dwc)
	dwc->gadget.max_speed		= USB_SPEED_SUPER;
	dwc->gadget.speed		= USB_SPEED_UNKNOWN;
	dwc->gadget.dev.parent		= dwc->dev;
+	dwc->gadget.sg_tablesize	= DWC3_TRB_NUM;

Waaa. So you want me to respect sg_table size in uasp. It is not done
yet.
Could we change sg_tablesize to sg_supported? So I don't have to support
it? From DWC3 point of view you just need to stop in the middle of
request and continue later. I don't think anyone has a restriction here
(I don't really know where this limit is comming from). If you don't
then I need to split the sg list into two or more requests which will
probably end up with the same thing. And, as recently learned a sg_list
of 4 entries could be mapped into one. If I have to split it manually we
may lose that.
If you really want an upper limit (which you copied from usb core where
it is treated as 0/1) then you could rename it so sg_entries or
something like that.

this is taken care of when we're kicking_transfers. See that we stop
when we run out of TRBs.

Yes, we stop. But I don't see that we resume at the point where we
stopped.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux