On Fri, Dec 16, 2011 at 04:09:27PM +0100, Sebastian Andrzej Siewior wrote: > * Felipe Balbi | 2011-12-16 03:40:02 [+0200]: > > >> > If more people would be willing to accept that possibility, I'm very > >> > eager to change the patch so that it would assume we have an unmapped > >> > request always. What do you say ? > >> > >> I'm not too concerned about breaking out-of-tree drivers. After all, > >> the kernel doesn't have a stable internal ABI. Have you checked the > >> in-tree drivers? I haven't. > >> > >> You could start off easy by leaving in the test and doing WARN_ONCE > >> if the DMA address is already set. Then if nothing shows up in > >> kerneloops, take it out entirely. > > > >aaaa haven't thought about that :-) Sounds like a great plan, will do > >:-) > > > >will check in tree drivers anyway :-D > > Great. While at it, can you please make udc-core provide a function like > map_urb_for_dma() does for the host side? This function would be called > by usb_ep_queue() just like the other one is called by > usb_hcd_submit_urb(). dude, this is what this patch is doing. -- balbi
Attachment:
signature.asc
Description: Digital signature
