On Fri, 16 Dec 2011, Felipe Contreras wrote:
> Properly call pm_runtime_put() afer pm_runttime_get() on errors.
>
> Untested.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>
> ---
> drivers/usb/musb/musb_gadget.c | 1 +
> drivers/usb/musb/omap2430.c | 1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
> index 922148f..95bfd2d 100644
> --- a/drivers/usb/musb/musb_gadget.c
> +++ b/drivers/usb/musb/musb_gadget.c
> @@ -1960,6 +1960,7 @@ static int musb_gadget_start(struct usb_gadget *g,
> err2:
> if (!is_otg_enabled(musb))
> musb_stop(musb);
> + pm_runtime_put(musb->controller);
> err0:
> return retval;
> }
> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
> index ba85f27..4edfb91 100644
> --- a/drivers/usb/musb/omap2430.c
> +++ b/drivers/usb/musb/omap2430.c
> @@ -385,6 +385,7 @@ static void omap2430_musb_disable(struct musb *musb)
>
> static int omap2430_musb_exit(struct musb *musb)
> {
> + pm_runtime_put(musb->controller);
> del_timer_sync(&musb_idle_timer);
>
> omap2430_low_level_exit(musb);
Should these calls be pm_runtime_put_sync() instead of
pm_runtime_put()?
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
