Hi, On Wed, Dec 14, 2011 at 05:39:51PM -0800, Neil Zhang wrote: > Hi Balbi, > > > -----Original Message----- > > From: Felipe Balbi [mailto:balbi@xxxxxx] > > Sent: 2011年12月14日 1:52 > > To: Neil Zhang > > Cc: balbi@xxxxxx; stern@xxxxxxxxxxxxxxxxxxx; gregkh@xxxxxxx; linux- > > usb@xxxxxxxxxxxxxxx; Chao Xie > > Subject: Re: [PATCH 01/10 v4] usb: gadget: mv_udc: drop ARCH dependency > > > > Hi, > > > > On Tue, Dec 13, 2011 at 08:13:44PM +0800, Neil Zhang wrote: > > > This patch do the following things: > > > 1. Change the Kconfig information. > > > 2. Rename the driver name. > > > 3. Don't do any type cast to io memory. > > > 4. Add dummy stub for clk framework. > > > > thanks :-) Will apply tomorrow. > > > > > Signed-off-by: Neil Zhang <zhangwm@xxxxxxxxxxx> > > > --- > > > drivers/usb/gadget/Kconfig | 10 +++++----- > > > drivers/usb/gadget/Makefile | 2 +- > > > drivers/usb/gadget/mv_udc.h | 2 +- > > > drivers/usb/gadget/mv_udc_core.c | 14 +++++++------- > > > include/linux/platform_data/mv_usb.h | 12 ++++++++++-- > > > 5 files changed, 24 insertions(+), 16 deletions(-) > > > > > > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig > > > index 23a4473..a591376 100644 > > > --- a/drivers/usb/gadget/Kconfig > > > +++ b/drivers/usb/gadget/Kconfig > > > @@ -310,13 +310,13 @@ config USB_S3C_HSUDC > > > > > > This driver has been tested on S3C2416 and S3C2450 processors. > > > > > > -config USB_PXA_U2O > > > - tristate "PXA9xx Processor USB2.0 controller" > > > - depends on ARCH_MMP > > > +config USB_MV_UDC > > > + tristate "Marvell USB2.0 Device Controller" > > > select USB_GADGET_DUALSPEED > > > help > > > - PXA9xx Processor series include a high speed USB2.0 device > > > - controller, which support high speed and full speed USB > > peripheral. > > > + Marvell Socs (including PXA and MMP series) include a high > > speed > > > + USB2.0 OTG controller, which can be configured as high speed or > > > + full speed USB peripheral. > > > > > > config USB_GADGET_DWC3 > > > tristate "DesignWare USB3.0 (DRD) Controller" > > > diff --git a/drivers/usb/gadget/Makefile > > b/drivers/usb/gadget/Makefile > > > index b54ac61..b7f6eef 100644 > > > --- a/drivers/usb/gadget/Makefile > > > +++ b/drivers/usb/gadget/Makefile > > > @@ -27,7 +27,7 @@ obj-$(CONFIG_USB_S3C_HSOTG) += s3c-hsotg.o > > > obj-$(CONFIG_USB_S3C_HSUDC) += s3c-hsudc.o > > > obj-$(CONFIG_USB_LANGWELL) += langwell_udc.o > > > obj-$(CONFIG_USB_EG20T) += pch_udc.o > > > -obj-$(CONFIG_USB_PXA_U2O) += mv_udc.o > > > +obj-$(CONFIG_USB_MV_UDC) += mv_udc.o > > > mv_udc-y := mv_udc_core.o > > > obj-$(CONFIG_USB_CI13XXX_MSM) += ci13xxx_msm.o > > > obj-$(CONFIG_USB_FUSB300) += fusb300_udc.o > > > diff --git a/drivers/usb/gadget/mv_udc.h > > b/drivers/usb/gadget/mv_udc.h > > > index daa75c1..de67f3d 100644 > > > --- a/drivers/usb/gadget/mv_udc.h > > > +++ b/drivers/usb/gadget/mv_udc.h > > > @@ -180,7 +180,7 @@ struct mv_udc { > > > > > > struct mv_cap_regs __iomem *cap_regs; > > > struct mv_op_regs __iomem *op_regs; > > > - unsigned int phy_regs; > > > + void __iomem *phy_regs; > > > unsigned int max_eps; > > > struct mv_dqh *ep_dqh; > > > size_t ep_dqh_size; > > > diff --git a/drivers/usb/gadget/mv_udc_core.c > > > b/drivers/usb/gadget/mv_udc_core.c > > > index 8924121..cd422ba 100644 > > > --- a/drivers/usb/gadget/mv_udc_core.c > > > +++ b/drivers/usb/gadget/mv_udc_core.c > > > @@ -2132,8 +2132,8 @@ static int __devexit mv_udc_remove(struct > > platform_device *dev) > > > udc->cap_regs = NULL; > > > > > > if (udc->phy_regs) > > > - iounmap((void *)udc->phy_regs); > > > - udc->phy_regs = 0; > > > + iounmap(udc->phy_regs); > > > + udc->phy_regs = NULL; > > > > do you need to set this to NULL ? Aren't you going to free udc anyway ? > > Yes, it seems useless. ok, do you want to send v2 ? -- balbi
Attachment:
signature.asc
Description: Digital signature
