On Tue, Dec 13, 2011 at 09:34:24AM -0800, Greg KH wrote: > On Tue, Dec 13, 2011 at 01:10:05PM +0200, Felipe Balbi wrote: > > On Mon, Dec 12, 2011 at 03:55:17PM -0800, Greg KH wrote: > > > On Mon, Dec 12, 2011 at 01:11:57PM +0200, Felipe Balbi wrote: > > > > Hi Greg, > > > > > > > > Here are MUSB patches for 3.3 merge window. Finally, after a long time > > > > of wait for a couple of these patches. > > > > > > > > The following changes since commit dc47ce90c3a822cd7c9e9339fe4d5f61dcb26b50: > > > > > > > > Linux 3.2-rc5 (2011-12-09 15:09:32 -0800) > > > > > > > > are available in the git repository at: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git for-next/musb > > > > > > > > Arnd Bergmann (2): > > > > usb: musb: use a Kconfig choice to pick the right DMA method > > > > usb: musb: allow building USB_MUSB_TUSB6010 as a module > > > > > > > > Felipe Balbi (3): > > > > usb: musb: headers cleanup > > > > usb: musb: drop ARCH dependency > > > > > > Now that I can build the musb driver, I get the following warnings on > > > an x86-64 system: > > > > > > drivers/usb/musb/musb_gadget.c: In function ‘musb_gadget_enable’: > > > drivers/usb/musb/musb_gadget.c:1085:3: warning: ‘double_buffer_not_ok’ is deprecated (declared at drivers/usb/musb/musb_core.h:452) [-Wdeprecated-declarations] > > > drivers/usb/musb/musb_gadget.c:1125:3: warning: ‘double_buffer_not_ok’ is deprecated (declared at drivers/usb/musb/musb_core.h:452) [-Wdeprecated-declarations] > > > drivers/usb/musb/musb_host.c: In function ‘musb_rx_reinit’: > > > drivers/usb/musb/musb_host.c:599:2: warning: ‘double_buffer_not_ok’ is deprecated (declared at drivers/usb/musb/musb_core.h:452) [-Wdeprecated-declarations] > > > drivers/usb/musb/musb_host.c: In function ‘musb_ep_program’: > > > drivers/usb/musb/musb_host.c:774:4: warning: ‘double_buffer_not_ok’ is deprecated (declared at drivers/usb/musb/musb_core.h:452) [-Wdeprecated-declarations] > > > > > > Have these warnings always been there? > > > > Yes, these are for the blackfin people who never got double buffer to > > work. I will put that on feature-removal-schedule. > > As you just added warnings to the build, for non-blackfin arches, it's > going to annoy the heck out of me and others now. > > Can you please fix it as soon as possible, otherwise stuff like this is > pointless, right? Mike, can you try to provide a patch fixing the double buffering on Blackfin's MUSB ? -- balbi
Attachment:
signature.asc
Description: Digital signature
