Re: [PATCHv8 02/19] usb: otg: Rename usb_otg and usb_xceiv to usb_phy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Dec 13, 2011 at 02:43:15AM +0000, Chen Peter-B29397 wrote:
> > 
> > Renames OTG_STATE_* to USB_PHY_STATE_*,
> 
> From my opinion, below are OTG/EH states, why they are needed to change to USB_PHY_STATE_*.
> And at ulpi/utmi+ spec where is no information of below states.
>  
> enum usb_otg_state {
>         OTG_STATE_UNDEFINED = 0,
> 
>         /* single-role peripheral, and dual-role default-b */
>         OTG_STATE_B_IDLE,
>         OTG_STATE_B_SRP_INIT,
>         OTG_STATE_B_PERIPHERAL,
> 
>         /* extra dual-role default-b states */
>         OTG_STATE_B_WAIT_ACON,
>         OTG_STATE_B_HOST,
> 
>         /* dual-role default-a */
>         OTG_STATE_A_IDLE,
>         OTG_STATE_A_WAIT_VRISE,
>         OTG_STATE_A_WAIT_BCON,
>         OTG_STATE_A_HOST,
>         OTG_STATE_A_SUSPEND,
>         OTG_STATE_A_PERIPHERAL,
>         OTG_STATE_A_WAIT_VFALL,
>         OTG_STATE_A_VBUS_ERR,
> };

states were define in OTG addendum, indeed. Still, I would say that only
B_HOST and A_PERIPHERAL are actual OTG roles. You can have a DRD device,
which doesn't support OTG at all (it can't do HNP, for example) but it
can still assume both roles based on cable or some register write.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux