On Mon, Dec 12, 2011 at 02:35:54PM -0800, Greg KH wrote: > On Mon, Dec 12, 2011 at 11:34:55AM +0800, Neil Zhang wrote: > > This patch adds support for EHCI compliant HSUSB Host controller found > > on Marvell Socs. > > > > It fits both OTG and SPH controller on marvell Socs, including > > PXA9xx/MMP2/MMP3/MGx. > > And it adds all sorts of compiler warnings to the build: > > In file included from drivers/usb/host/ehci-hcd.c:1375:0: > drivers/usb/host/ehci-mv.c: In function ‘mv_ehci_enable’: > drivers/usb/host/ehci-mv.c:63:5: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > drivers/usb/host/ehci-mv.c: In function ‘mv_ehci_disable’: > drivers/usb/host/ehci-mv.c:75:5: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > drivers/usb/host/ehci-mv.c: In function ‘mv_ehci_probe’: > drivers/usb/host/ehci-mv.c:237:39: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > drivers/usb/host/ehci-mv.c:237:21: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] > drivers/usb/host/ehci-mv.c:292:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > drivers/usb/host/ehci-mv.c:293:9: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] > > Please send a follow-on patch to fix this, and next time, be more > careful. Actually, no, I'm not going to accept this, as it's obviously wrong on systems where an int is not the size of a pointer, which is the primary platform for Linux these days. Please fix the code up before sending it again. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
