Re: [RFC 5/9] UAS: Introduce an URB anchor for command cancellation.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Sarah Sharp | 2011-12-02 11:55:51 [-0800]:

>@@ -726,19 +742,28 @@ static int uas_probe(struct usb_interface *intf, const struct usb_device_id *id)
> 	shost->max_id = 1;
> 	shost->sg_tablesize = udev->bus->sg_tablesize;
> 
>-	result = scsi_add_host(shost, &intf->dev);
>-	if (result)
>-		goto free;
>-	shost->hostdata[0] = (unsigned long)devinfo;
>-
> 	devinfo->intf = intf;
> 	devinfo->udev = udev;
> 	uas_configure_endpoints(devinfo);
>+	devinfo->anchors = kmalloc(sizeof(*devinfo->anchors)*devinfo->qdepth,

xhci_alloc_streams() returns the number of supported stream minus one
for the taken stream 0. Why do you substruct one from qdepth in
uas_slave_configure()? This does not look like 1:1 mapping between
streams <-> scsi command and its urbs.
On HS we can only send one command at a time as we have only one stream,
right? But qdepth is set to 256 which makes you here allocate 256
anchors for only one command at a time.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux