Re: [PATCH 19/21] xHCI: fix bug in xhci_clear_command_ring()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 02, 2011 at 03:46:28PM -0800, Sarah Sharp wrote:
> On Fri, Dec 02, 2011 at 01:52:43PM -0800, Greg Kroah-Hartman wrote:
> > From: Andiry Xu <andiry.xu@xxxxxxx>
> > 
> > When system enters suspend, xHCI driver clears command ring by writing zero
> > to all the TRBs. However, this also writes zero to the Link TRB, and the ring
> > is mangled. This may cause driver accesses wrong memory address and the
> > result is unpredicted.
> > 
> > When clear the command ring, keep the last Link TRB intact, only clear its
> > cycle bit. This should fix the "command ring full" issue reported by Oliver
> > Neukum.
> > 
> > This should be backported to stable kernels as old as 2.6.37, since the
> > commit 89821320 "xhci: Fix command ring replay after resume" is merged.
> > 
> > Signed-off-by: Andiry Xu <andiry.xu@xxxxxxx>
> > Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>
> > Reported-by: Oliver Neukum <oneukum@xxxxxxx>
> 
> I also forgot to Cc stable for this patch.  Where is my head this week?

No problem, I'll apply it, thanks for letting me know.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux