Re: [PATCH] usb/dwc3: use dwc3_request for ep0 requsts instead of usb_request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 25, 2011 at 12:13:36PM +0100, Sebastian Andrzej Siewior wrote:
> On 11/25/2011 12:06 PM, Felipe Balbi wrote:
> >On Fri, Nov 25, 2011 at 12:03:46PM +0100, Sebastian Andrzej Siewior wrote:
> >>Instead of special functions and shortcuts for sending our internal
> >>answers to the host we started doing what the gadget does and used the
> >>public API for this. Since we only were using a few fields the
> >>usb_request was enough. Later added the list handling in order to
> >>synchronize the host / gadget events and now we require to have the
> >>dwc3_request struct around our usb_request or else we touch memory that
> >>does not belong to us. So this patch does this.
> >>
> >>Reported-by: Partha Basak<p-basak2@xxxxxx>
> >>Signed-off-by: Sebastian Andrzej Siewior<bigeasy@xxxxxxxxxxxxx>
> >
> >Although this hasn't triggered yet, I'm quite confident it's a needed
> >fix. Queueing as fix, will send pull request later on today.
> 
> Probably didn't trigger because nobody issued the get status request.
> Can g_zero do that?

it already does, it's part of test_ctrl_queue() on
drivers/usb/misc/usbtest.c

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux