Re: [PATCH] usb, davinci: remove USB_MUSB_* defines in davinci usb setup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 24-11-2011 15:49, Felipe Balbi wrote:

commit 622859634a663c5e55d0e2a2cdbb55ac058d97b3
Author: Felipe Balbi<balbi@xxxxxx>
Date:   Wed Jun 22 17:28:09 2011 +0300

     usb: musb: drop a gigantic amount of ifdeferry

dropped a lot of ifdefs, also the USB_MUSB_HOST, USB_MUSB_PERIPHERAL
and USB_MUSB_OTG defines, which are used in arch/arm/mach-davinci/usb.c

Drop them in arch/arm/mach-davinci/usb.c and set otg as mode.

Signed-off-by: Heiko Schocher<hs@xxxxxxx>
Cc: Felipe Balbi<balbi@xxxxxx>
Cc: Sergei Shtylyov<sshtylyov@xxxxxxxxxxxxx>
Cc: linux-usb@xxxxxxxxxxxxxxx
Cc: Wolfgang Denk<wd@xxxxxxx>

FWIW, this is ok from my point of view:

Acked-by: Felipe Balbi<balbi@xxxxxx>

IMHO, it needs more detailed comments, explaining why it's OK to always set MUSB_OTG now... Also, we need another patch dropping #ifdef from arch/arm/mach-davinci/board-da830-evm.c...

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux