Re: [PATCH 30/34] usb: dwc3: gadget: return early in dwc3_cleanup_done_reqs()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 24, 2011 at 12:29:23PM +0100, Sebastian Andrzej Siewior wrote:
> On 11/24/2011 12:22 PM, Felipe Balbi wrote:
> >On Thu, Nov 24, 2011 at 03:16:16PM +0400, Sergei Shtylyov wrote:
> >>>This is only uninitialized if the list of to-cleanup TRBs is empty which
> >>>should not be the case because we call this functions once a transfer
> >>>completed so it should be on list. We return early in the which should
> >>
> >>    In the which? :-)
> >
> >Sebastian, what should I change this for ?
> 
> Replace the last one "We return..." with
> 
> |In order to make the warning disappear we return early. This should
> |never happen and the WARN_ON_ONCE(1) is there in case it happens
> |so we can investigate what went wrong.
> 
> please.

done, tks

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux