On Wed, 23 Nov 2011 18:10:41 +0100, Arvid Brodin wrote:
@@ -403,12 +410,12 @@ static int priv_init(struct usb_hcd *hcd)
{
struct isp1760_hcd *priv = hcd_to_priv(hcd);
u32 hcc_params;
+ int i;
Michal Nazarewicz wrote:
How about unsigned?
On Wed, 23 Nov 2011 19:02:55 +0100, Arvid Brodin wrote:
No. I'm comparing 'i' to QH_END, which is an enumerated constant.
According to the C90 standard, these are of type int. Mixing signed
and unsigned in the same expression is never a good idea in C.
Often the behaviour is up to the compiler implementation. I believe
it would work here, but why take the chance?
You have a point there (even if Linux is closer to C99 than C90 ;) ).
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michał “mina86” Nazarewicz (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
