On Tue, 22 Nov 2011, Felipe Balbi wrote: > Hi all, > > Here's an unfinished version of SG list support on > Gadget framework. > > Before going any further I would like to hear from the > rest of the community what do you guys think about the > approach. > > See that the DWC3 support is unfinished and still lacks > the actual TRB programming, but all the memory allocations > and the basic skeleton for sg_prepare() (the real meat) is > pretty much done. > > Any tips, concerns, comments are welcome, of course. In addition to what Sebastian pointed out, the API is missing a piece. A gadget driver needs to know whether or not the UDC driver supports SG operations and how large an SG list may become. There should be a "sg_max_tablesize" field (or some name like that) added to struct usb_gadget; if the field is 0 then SG operations aren't supported. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
