Re: [PATCH 2/2] usb: fsl_mxc_udc.c: Fix build issue by including missing header file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Felipe,

On Tue, Nov 22, 2011 at 11:21 AM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> On Tue, Nov 22, 2011 at 10:31 AM, Felipe Balbi <balbi@xxxxxx> wrote:
>
>> it looks like this driver either never compiled or some recent commit
>> broke it. It would be nice to know which commit caused the failure.
>
> The read/write functions on this driver were introduced by commit 69cb1ec4
> (mxc_udc: add workaround for ENGcm09152 for i.MX35)

I did more research on this and the commit that broke the fsl_mxc_udc
driver for MX35 was:
(f16fcb63: arm/imx: remove mx31_setup_weimcs( ) from mx31.h).

This commit removed #include <linux/io.h> from mx31.h.

 fsl_mxc_udc.c includes <mach/hardware.h>, which includes mx31.h, so
that's why it built fine previously.

I wil add this explanation in the commit log and send the v2 version.
I will also send another patch that removes the
#if defined(CONFIG_SOC_IMX35).

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux