Re: [PATCH 22/48] USB: ci13xxx_udc: fix debug trace code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 21 Nov 2011 17:11:36 -0800, Greg Kroah-Hartman <gregkh@xxxxxxx> wrote:
> From: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> 
> This patch fixes the following compile errors that show up if switching
> on the debug trace code:
> 
> drivers/usb/gadget/ci13xxx_udc.c: In function 'ci13xxx_wakeup':
> drivers/usb/gadget/ci13xxx_udc.c:2517:3: error: 'dev' undeclared (first use in this function)
> drivers/usb/gadget/ci13xxx_udc.c:2517:3: note: each undeclared identifier is reported only once for each function it appears in
> drivers/usb/gadget/ci13xxx_udc.c: In function 'udc_probe':
> drivers/usb/gadget/ci13xxx_udc.c:2867:2: error: 'name' undeclared (first use in this function)
> 
> Tested-by: Pavankumar Kondeti <pkondeti@xxxxxxxxxxxxxx>

Tested-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>

> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> ---
>  drivers/usb/gadget/ci13xxx_udc.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/gadget/ci13xxx_udc.c b/drivers/usb/gadget/ci13xxx_udc.c
> index 4241241..9a0c397 100644
> --- a/drivers/usb/gadget/ci13xxx_udc.c
> +++ b/drivers/usb/gadget/ci13xxx_udc.c
> @@ -2503,12 +2503,12 @@ static int ci13xxx_wakeup(struct usb_gadget *_gadget)
>  	spin_lock_irqsave(udc->lock, flags);
>  	if (!udc->remote_wakeup) {
>  		ret = -EOPNOTSUPP;
> -		dbg_trace("remote wakeup feature is not enabled\n");
> +		trace("remote wakeup feature is not enabled\n");
>  		goto out;
>  	}
>  	if (!hw_cread(CAP_PORTSC, PORTSC_SUSP)) {
>  		ret = -EINVAL;
> -		dbg_trace("port is not suspended\n");
> +		trace("port is not suspended\n");
>  		goto out;
>  	}
>  	hw_cwrite(CAP_PORTSC, PORTSC_FPR, PORTSC_FPR);
> @@ -2855,7 +2855,7 @@ static int udc_probe(struct ci13xxx_udc_driver *driver, struct device *dev,
>  	struct ci13xxx *udc;
>  	int retval = 0;
>  
> -	trace("%p, %p, %p", dev, regs, name);
> +	trace("%p, %p, %p", dev, regs, driver->name);
>  
>  	if (dev == NULL || regs == NULL || driver == NULL ||
>  			driver->name == NULL)
> -- 
> 1.7.7.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux