Re: Support from mainline Linux Kernel for new 3G USB device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi VU,

> Dear Mr. Greg Kroah-Hartman,
> 
> As you recommended, I made a patch for the latest stable Linux kernel
> 3.1.1.
> 
> Description: Adding VendorID/ProductID for USB 3G dongle Model VT1000 of
> Viettel. Signed-off-by:  VU Tuan Duc <ducvt@xxxxxxxxxxxxxx>
> 

This is almost good, Can you try git send-email next time ? ;-)

> --- linux-3.1.1/drivers/usb/serial/option.c.orig	2011-11-15
> 09:19:31.000000000 +0700 +++
> linux-3.1.1/drivers/usb/serial/option.c	2011-11-15 09:26:03.000000000
> +0700 @@ -468,6 +468,10 @@ static void option_instat_callback(struc
> #define YUGA_PRODUCT_CLU528			0x260D
> #define YUGA_PRODUCT_CLU526			0x260F
> 
> +/* Viettel products */
> +#define VIETTEL_VENDOR_ID			0x2262
> +#define VIETTEL_PRODUCT_VT1000			0x0002
> +
> /* some devices interfaces need special handling due to a number of reasons
> */ enum option_blacklist_reason {
> 		OPTION_BLACKLIST_NONE = 0,
> @@ -1141,6 +1145,7 @@ static const struct usb_device_id option
> 	{ USB_DEVICE(YUGA_VENDOR_ID, YUGA_PRODUCT_CLU516) },
> 	{ USB_DEVICE(YUGA_VENDOR_ID, YUGA_PRODUCT_CLU528) },
> 	{ USB_DEVICE(YUGA_VENDOR_ID, YUGA_PRODUCT_CLU526) },
> +	{ USB_DEVICE_AND_INTERFACE_INFO(VIETTEL_VENDOR_ID,
> VIETTEL_PRODUCT_VT1000, 0xff, 0xff, 0xff) }, { } /* Terminating entry */

Plain USB_DEVICE() won't do ?


> };
> MODULE_DEVICE_TABLE(usb, option_ids);
> 
> 
> Thanks & Best Regards,

M

> 
> VU Tuan Duc
> 
> On Nov 15, 2011, at 4:52 AM, Greg KH wrote:
> > On Wed, Nov 02, 2011 at 11:20:44AM +0700, VU Tuan Duc wrote:
> >> Dear Mr. Greg Kroah-Hartman,
> >> 
> >> Based on your guide, I created a patch for USB driver GSM Modem
> >> drivers/usb/serial/option.c. Patch using diff -up:
> >> Description: Adding VendorID/Product ID (0x2262/0x0002) for USB 3G
> >> dongle Model VT1000 of Viettel. It makes option.ko module to bind with
> >> VT1000 device.
> >> 
> >> --- linux-2.6.32/drivers/usb/serial/option.c.orig	2011-11-02
> >> 09:22:55.000000000 +0700 +++
> >> linux-2.6.32/drivers/usb/serial/option.c	2011-11-02 09:28:43.000000000
> >> +0700
> > 
> > Unfortunatly, the 2.6.32 kernel is quite old, can you redo this patch
> > against the 3.1 kernel release from kernel.org and send me a new patch?
> > 
> > Also, I need a "Signed-off-by:" line as described in the file,
> > Documentation/SubmittingPatches, in order to be able to apply the patch
> > so be sure to include that with the new patch.
> > 
> > thanks,
> > 
> > greg k-h
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux