On 22:39 Mon 14 Nov , Andrew Victor wrote: > hi, > > > in commit aa6e52a35 we introduce the support of overcurrent notification > > but the set and get of the power without checking if the gpio is valid or not > > > + if (pdata->vbus_pin[port] <= 0) > > + return; > > Shouldn't that rather be: > if (!gpio_is_valid(pdata->vbus_pin[port])) > return; Yes should be but 0 is not a valid gpio on at91 I've a patch serie to fix the gpio support for at91 so we can use gpio_is_valid for 3.3 Best Regards, J. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
