[PATCH 0/7] USB: serial: clean up error handling in open

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, 

As Oliver pointed out we should not be returning USB specific error codes to
user-space which currently almost all serial drivers do. The first two patches
makes sure that all errors returned from serial_open in usb-serial are
re-mapped using usb_translate_errors.

The last five patches makes sure that all errors from the stack are actually
forwarded to usb-serial core in open (some drivers returned -EPROTO rather than
the valid -ENOMEM, for example). It's better to be consistent and do the
re-map in one place for all drivers.

Thanks,
Johan


Johan Hovold (7):
  USB: move usb_translate_errors to linux/usb.h
  USB: serial: do not forward USB specific errors in open
  USB: ch341: forward USB errors to USB serial core
  USB: cp210x: forward USB errors to USB serial core
  USB: iuu_phoenix: forward USB errors to USB serial core
  USB: oti6858: remove dead code
  USB: oti6858: forward USB errors to USB serial core

 drivers/usb/core/usb.h           |   14 --------------
 drivers/usb/serial/ch341.c       |    2 +-
 drivers/usb/serial/cp210x.c      |   19 +++++++++++++------
 drivers/usb/serial/iuu_phoenix.c |    3 +--
 drivers/usb/serial/oti6858.c     |   14 +-------------
 drivers/usb/serial/usb-serial.c  |    3 ++-
 include/linux/usb.h              |   13 +++++++++++++
 7 files changed, 31 insertions(+), 37 deletions(-)

-- 
1.7.7.2

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux