Re: USB: serial: cp210x.c: add mark/space parity

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 09, 2011 at 02:33:13PM +0100, Roland Koebler wrote:
> Hi,
> 
> nearly all usb-serial-converters support mark/space parity, but
> unfortunately, most drivers in the Linux kernel ignore this.
> 
> So, this patch adds mark and space parity support to cp210x.c
> It should work with both 2.6.x and 3.x kernels.

Thanks for the patch, but could you resend it after formatting it as
described in Documentation/SubmittingPatches so that I can apply it
(hint, you need to change the patch level and provide a signed-off-by:
line.)

> --- cp210x.orig.c	2011-11-09 14:07:29.000000000 +0100
> +++ cp210x.c	2011-11-09 14:17:40.000000000 +0100
> @@ -9,7 +9,8 @@
>   *
>   * Support to set flow control line levels using TIOCMGET and TIOCMSET
>   * thanks to Karl Hiramoto karl@xxxxxxxxxxxx. RTSCTS hardware flow
> - * control thanks to Munir Nassar nassarmu@xxxxxxxxxxxxx
> + * control thanks to Munir Nassar nassarmu@xxxxxxxxxxxxx. Mark/space
> + * parity thanks to Roland Koebler rk@xxxxxxxxxxx.

Also, this line isn't needed as it will show in the changelog that you
provided this information.

Also these lines are about to be removed from the driver anyway, as
changelog information doesn't belong in the code.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux