On Tue, Nov 08, 2011 at 11:27:12AM +0530, ABRAHAM, KISHON VIJAY wrote: > Hi Heikki, > > On Fri, Oct 28, 2011 at 6:05 PM, Heikki Krogerus > <heikki.krogerus@xxxxxxxxxxxxxxx> wrote: > > This is the first step in separating USB transceivers from > > USB OTG utilities. > > > > Includes fixes to IMX code from Sascha Hauer. > > I tend to defer with your opinion of renaming otg_transceiver to > usb_phy. According to me otg_transceiver should program hardware > mechanisms associated to VBUS, ID lines, etc.. and phy is responsible > for transmitting data over differential data lines (with its own > programming of phy_init, phy_shutdown, setting phy clocks etc..). So > in my opinion otg_transceiver and usb_phy should be two different and > separate entities. > I am a little puzzled, are there two separate analog usb parts at OMap 's usb part? What the transceiver do? And what the phy do? > I would have preferred to rename otg_transceiver as usb_otg as the > first step. (this differs from your implementation where you rename > otg_transceiver to usb_phy and create a new structure usb_otg to > separate otg members from usb_phy). > > But it should have been first rename otg_transceiver as usb_otg. Then > create a new structure usb_phy to move all the phy specific > implementation there. This kind of implementation will also help when > we want to have independent phy drivers. > > Thanks > Kishon > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
