On 11/08/2011 12:27 PM, Felipe Balbi wrote:
On Fri, Nov 04, 2011 at 12:31:20PM +0100, Daniel Mack wrote:
The dynamic jack allocation of the MIDI gadget currently links all
external jacks to one single instance of an embedded jack. According to
chapter 3.3.1 of the USB MIDI 1.0 spec, this is only valid if these
streams always carry the same data stream.
Also, with the current implementation, Windows 7(tm) will blue-screen
instantly once a device featuring more than one input and output MIDI
port connected.
While at it, and because it grew again by this change, allocate the
temporary function pointer list on the heap, not on the stack.
is this really fixing a bug on the driver ? or can it wait for 3.3 merge
window ?
It's fixing a bug in the behaviour of the gadget towards the USB host. I
would say this justifies it going into 3.2, but it's not super urgent.
As long as it's queued and I can forget about it, I'm fine :)
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
