Re: [PATCH 2/2] USB: update last_busy time after autosuspend fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, November 04, 2011, Greg KH wrote:
> On Thu, Nov 03, 2011 at 11:47:34PM +0100, Rafael J. Wysocki wrote:
> > On Thursday, November 03, 2011, Alan Stern wrote:
> > > Originally, the runtime PM core would send an idle notification
> > > whenever a suspend attempt failed.  The idle callback routine could
> > > then schedule a delayed suspend for some time later.
> > > 
> > > However this behavior was changed by commit
> > > f71648d73c1650b8b4aceb3856bebbde6daa3b86 (PM / Runtime: Remove idle
> > > notification after failing suspend).  No notifications were sent, and
> > > there was no clear mechanism to retry failed suspends.
> > > 
> > > This caused problems for the usbhid driver, because it fails
> > > autosuspend attempts as long as a key is being held down.  A companion
> > > patch changes the PM core's behavior, but we also need to change the
> > > USB core.  In particular, this patch (as1493) updates the device's
> > > last_busy time when an autosuspend fails, so that the PM core will
> > > retry the autosuspend in the future when the delay time expires
> > > again.
> > > 
> > > Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> > > Tested-by: Henrik Rydberg <rydberg@xxxxxxxxxxx>
> > > CC: <stable@xxxxxxxxxx>
> > 
> > Greg, are you going to take this one or do you want me to do that?
> 
> oops, as you took patch 1/2, might as well take this one as well:
> 	Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

OK, I will, thanks!

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux