Silently doing nothing when a break is requested but fails is not the most user-friendly behaviour. Convert the existing debug message to a proper error message. Signed-off-by: Nick Bowler <nbowler@xxxxxxxxxxxxxxxx> --- drivers/usb/serial/pl2303.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c index 9083d1e..0f3c506 100644 --- a/drivers/usb/serial/pl2303.c +++ b/drivers/usb/serial/pl2303.c @@ -673,7 +673,7 @@ static void pl2303_break_ctl(struct tty_struct *tty, int break_state) BREAK_REQUEST, BREAK_REQUEST_TYPE, state, 0, NULL, 0, 100); if (result) - dbg("%s - error sending break = %d", __func__, result); + dev_err(&port->dev, "failed to send break: %d\n", result); } static void pl2303_release(struct usb_serial *serial) -- 1.7.3.4 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html